Skip to content

Conversation

j1m-ryan
Copy link

@j1m-ryan j1m-ryan commented Aug 9, 2024

Proposed changes

Add image pull secret name variable to makefile
This will add imagePullSecrets: with a secret name to the deployment.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@j1m-ryan j1m-ryan requested a review from a team as a code owner August 9, 2024 14:55
@github-actions github-actions bot added the chore Pull requests for routine tasks label Aug 9, 2024
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Aug 13, 2024
@j1m-ryan j1m-ryan merged commit 72c75ca into main Aug 13, 2024
@j1m-ryan j1m-ryan deleted the chore/add-image-pull-secret-name-to-makefile branch August 13, 2024 09:14
@pdabelf5 pdabelf5 linked an issue Aug 13, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks documentation Pull requests/issues for documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

POC - Operator - Image registry consolidation

4 participants