Skip to content

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Dec 20, 2023

Proposed changes

operator version was being incorrectly supplied as vv2.1.0

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner December 20, 2023 15:29
@lucacome
Copy link
Contributor

https://github.com/nginxinc/nginx-ingress-helm-operator/blob/0e84bbda3d8453629f96b9a3feabd1f214924c2f/.github/workflows/ci.yml#L28

This was set to the wrong variable, you can just change this to steps.meta.outputs.version and everything works

@pdabelf5 pdabelf5 force-pushed the operator-pr-version branch from 4f4ba2d to 300ed00 Compare December 21, 2023 12:47
@pdabelf5 pdabelf5 merged commit 1aef758 into main Dec 21, 2023
@pdabelf5 pdabelf5 deleted the operator-pr-version branch December 21, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants