Skip to content

Update installation.md to include a clarification on the instructions #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update installation.md to include a clarification on the instructions #977

wants to merge 1 commit into from

Conversation

mkiehl
Copy link

@mkiehl mkiehl commented Aug 16, 2023

Add a note that a gateway resource must be configured in order for the NGINX Kubernetes Gateway to start listening on the assigned ports.

Proposed changes

Problem: I followed the installation instructions and then spent time debugging why I couldn't reach the nginx server using the NodePort.

Solution: Add a note to the instructions that a gateway resource must be configured. A similar note is already contained in the kind installation instructions but not in the generic installation guide.

Testing: N/A

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Add a note that a gateway resource must be configured in order for the NGINX Kubernetes Gateway to start listening on the assigned ports.
@mkiehl mkiehl requested a review from a team as a code owner August 16, 2023 08:14
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 16, 2023
@@ -58,6 +58,11 @@ You can gain access to NGINX Kubernetes Gateway by creating a `NodePort` Service
> configured for those ports. If you'd like to use different ports in your listeners,
> update the manifests accordingly.

> Important
>
> NGINX Kubernetes Gateway will not listen on any ports until you configure a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> NGINX Kubernetes Gateway will not listen on any ports until you configure a
> NGINX will not listen on any ports until you configure a

@ciarams87
Copy link
Contributor

ciarams87 commented Aug 16, 2023

Hi @mkiehl, thank you for your interest in the project!

Could you please open an issue and include the issue number in the PR description? Also the markdown lint check is failing - the details can be seen here.

@kate-osborn
Copy link
Contributor

Closing this in favor of: #1153

Thanks @mkiehl for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants