Remove njs-modules configmap #959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjberman
approved these changes
Aug 11, 2023
|
Looks like there are a couple more |
github-actions
bot
added
the
documentation
Removed. Thanks for catching! |
pleshakov
approved these changes
Aug 11, 2023
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
Problem: PR nginx#934 did not remove the njs-modules ConfigMap and they are some lingering references to it. Solution: Remove the njs modules ConfigMap and remove references.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: PR #934 did not remove the njs modules configmap from the manifests directory.
Solution: Remove the njs modules configmap.
Checklist
Before creating a PR, run through this checklist and mark each as complete.