Fix function calls with inconsistent argument breaking #932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: - The code doesn't follow the guideline: when breaking up a call, choose to break after each parameter argument. See https://github.com/nginxinc/nginx-kubernetes-gateway/blob/0ff13226b16cfec44f509542b25bc3f2fcf610cc/docs/developer/go-style-guide.md#consistent-line-breaks - THe guidelines don't have an example of a function call Solution: - Fix the problems in the code, except for ginkgo helpers in tests, because of their readability. - Add an example of a functional call to the guidelines
github-actions
bot
added
documentation
sjberman
approved these changes
Aug 2, 2023
ciarams87
approved these changes
Aug 3, 2023
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
Problem: - The code doesn't follow the guideline: when breaking up a call, choose to break after each parameter argument. See https://github.com/nginxinc/nginx-kubernetes-gateway/blob/0ff13226b16cfec44f509542b25bc3f2fcf610cc/docs/developer/go-style-guide.md#consistent-line-breaks - THe guidelines don't have an example of a function call Solution: - Fix the problems in the code, except for ginkgo helpers in tests, because of their readability. - Add an example of a functional call to the guidelines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem:
Solution:
Testing: N/A
Closes N/A
Note: this was promised in the PR review -- #905 (comment)
Checklist
Before creating a PR, run through this checklist and mark each as complete.