Skip to content

Add requirements for Docker image in examples #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 16, 2023
Merged

Add requirements for Docker image in examples #756

merged 4 commits into from
Jun 16, 2023

Conversation

@pleshakov
Copy link
Contributor

@pleshakov pleshakov commented Jun 15, 2023

Proposed changes

Problems:

  • For security, we want to use Docker images we can trust -- either managed by NGINX or F5 or an official Docker images.
  • We want contributors to be aware of that requirement.

Solution:

  • Add requirements to the developer docs.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pleshakov
Add requirements for Docker image in examples
0ba0378 
Problems:
- For security, we want to use Docker images we can trust -- either
managed by NGINX or F5 or an official Docker images.
- We want contributors to be aware of that requirement.

Solution:
- Add requirements to the developer docs.
@pleshakov pleshakov requested a review from a team as a code owner June 15, 2023 16:53
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 15, 2023
@pleshakov pleshakov merged commit f64d045 into nginx:main Jun 16, 2023
@pleshakov pleshakov deleted the docs/clarify-example-docker-images branch June 16, 2023 21:45
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
@miledxz
Add requirements for Docker image in examples (nginx#756)
0aa6c54 
Problems:
- For security, we want to use Docker images we can trust -- either
managed by NGINX or F5 or an official Docker images.
- We want contributors to be aware of that requirement.

Solution:
- Add requirements to the developer docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjberman sjberman sjberman approved these changes

+1 more reviewer

@kate-osborn kate-osborn kate-osborn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pleshakov @sjberman @kate-osborn