Improve provisioner docs #741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: It is not obvious that it is necessary to re-build the NKG image to customize the static mode Deployment, which the provisioner uses. Solution: Make the docs clearer.
github-actions
bot
added
the
documentation
sjberman
reviewed
Jun 12, 2023
Co-authored-by: Saylor Berman <[email protected]>
kate-osborn
suggested changes
Jun 12, 2023
Co-authored-by: Kate Osborn <[email protected]>
kate-osborn
approved these changes
Jun 12, 2023
ciarams87
approved these changes
Jun 13, 2023
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
Problem: It is not obvious that it is necessary to re-build the NKG image to customize the static mode Deployment, which the provisioner uses. Solution: Make the docs clearer. --------- Co-authored-by: Saylor Berman <[email protected]> Co-authored-by: Kate Osborn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem:
It is not obvious that it is necessary to re-build the NKG image to customize the static mode Deployment, which the provisioner uses.
Solution:
Make the docs clearer.
Checklist
Before creating a PR, run through this checklist and mark each as complete.