Skip to content

Conversation

@salonichf5
Copy link
Contributor

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: Users want to enable conformance tests to ensure correct checks are in place

Solution: Enables conformance test

Testing: Manually being tested still.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #3842

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

Enable conformance tests for Inference Extension

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 16, 2025
@salonichf5 salonichf5 marked this pull request as ready for review October 16, 2025 19:50
@salonichf5 salonichf5 requested a review from a team as a code owner October 16, 2025 19:50
@github-project-automation github-project-automation bot moved this from 🆕 New to 🏗 In Progress in NGINX Gateway Fabric Oct 16, 2025
@salonichf5 salonichf5 requested a review from ciarams87 October 16, 2025 20:46
@salonichf5 salonichf5 requested a review from bjee19 October 17, 2025 00:01
Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gonna leave my approval here awaiting conformance tests passing

Copy link
Contributor

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your perseverance in getting this over the line 🚀 🔥

@salonichf5 salonichf5 merged commit 14feda2 into feat/inference-extension Oct 17, 2025
93 of 94 checks passed
@salonichf5 salonichf5 deleted the tests/iec branch October 17, 2025 01:23
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in NGINX Gateway Fabric Oct 17, 2025
ciarams87 pushed a commit that referenced this pull request Oct 17, 2025
Enable conformance tests for Inference Extension

Co-author: Ciara Stacker <[email protected]>
ciarams87 pushed a commit that referenced this pull request Oct 17, 2025
Enable conformance tests for Inference Extension

Co-author: Ciara Stacker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation release-notes

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants