-
Notifications
You must be signed in to change notification settings - Fork 135
feat: Support ExternalName Services #3759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3759 +/- ##
==========================================
+ Coverage 86.87% 87.00% +0.13%
==========================================
Files 128 128
Lines 16202 16404 +202
Branches 62 62
==========================================
+ Hits 14075 14273 +198
- Misses 1953 1956 +3
- Partials 174 175 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
474d729
to
9fbb003
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I make one small request to be added in this PR? Though irrelevant, I don't think it warrants a brand new PR.
In the servers nginx template, right after js_preload_object
, can you add another newline? I've noticed in some rendered nginx configs, a server block renders on the same line and it looks off.
9fbb003
to
1608048
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks great from what I can see. Left two comments that aren't blocking the PR. Great job @ciarams87! 🎉
Problem: NGF does not support routing to services outside the cluster Solution: Add support for ExternalName type Services
75e8c95
to
b5c2241
Compare
Proposed changes
Problem: NGF does not support routing to services outside the cluster
Solution: Add support for ExternalName type Services.
Testing: Tested locally targeting httpbin.org for both HTTPRoute and TLSRoute
Closes #243
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.