Feat: Add helm values for cert-generator Job pod placement #3493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @baburciu! Welcome to the project! 🎉 Thanks for opening this pull request! Please make sure to include the issue number in the PR description to automatically close the issue when the PR is merged. |
|
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
|
I have hereby read the F5 CLA and agree to its terms |
|
recheck |
baburciu
force-pushed
the
baburciu/cert-generator-pod-placement
branch
2 times, most recently
from
80f101a to
8d06c3e
Compare
github-actions
bot
added
the
documentation
baburciu
force-pushed
the
baburciu/cert-generator-pod-placement
branch
from
8d06c3e to
359e68f
Compare
baburciu
force-pushed
the
baburciu/cert-generator-pod-placement
branch
from
359e68f to
10487dc
Compare
sjberman
reviewed
Jun 11, 2025
sjberman
reviewed
Jun 11, 2025
sjberman
approved these changes
Jun 11, 2025
salonichf5
pushed a commit
that referenced
this pull request
Jun 11, 2025
Problem: Deploying the new version 2.0.0 chart we see the Job/foo-cert-generator pod stuck on pending scheduling when all cluster nodes have taints.
Solution: Add the ability to inject job.spec.template.spec.{affinity,nodeSelector,tolerations,topologySpreadConstraints} to alter pod placement. If you prefer to only add a subset of these, like only tolerations was needed in my case, please do inform and I can adjust.
sjberman
pushed a commit
that referenced
this pull request
Jun 11, 2025
Feat: Add helm values for cert-generator Job pod placement (#3493) Problem: Deploying the new version 2.0.0 chart we see the Job/foo-cert-generator pod stuck on pending scheduling when all cluster nodes have taints. Solution: Add the ability to inject job.spec.template.spec.{affinity,nodeSelector,tolerations,topologySpreadConstraints} to alter pod placement. If you prefer to only add a subset of these, like only tolerations was needed in my case, please do inform and I can adjust. Co-authored-by: Bogdan-Adrian Burciu <[email protected]>
nowjean
pushed a commit
to nowjean/nginx-gateway-fabric
that referenced
this pull request
Jun 14, 2025
Problem: Deploying the new version 2.0.0 chart we see the Job/foo-cert-generator pod stuck on pending scheduling when all cluster nodes have taints.
Solution: Add the ability to inject job.spec.template.spec.{affinity,nodeSelector,tolerations,topologySpreadConstraints} to alter pod placement. If you prefer to only add a subset of these, like only tolerations was needed in my case, please do inform and I can adjust.
nowjean
pushed a commit
to nowjean/nginx-gateway-fabric
that referenced
this pull request
Jun 14, 2025
Problem: Deploying the new version 2.0.0 chart we see the Job/foo-cert-generator pod stuck on pending scheduling when all cluster nodes have taints.
Solution: Add the ability to inject job.spec.template.spec.{affinity,nodeSelector,tolerations,topologySpreadConstraints} to alter pod placement. If you prefer to only add a subset of these, like only tolerations was needed in my case, please do inform and I can adjust.
nowjean
pushed a commit
to nowjean/nginx-gateway-fabric
that referenced
this pull request
Jun 14, 2025
Problem: Deploying the new version 2.0.0 chart we see the Job/foo-cert-generator pod stuck on pending scheduling when all cluster nodes have taints.
Solution: Add the ability to inject job.spec.template.spec.{affinity,nodeSelector,tolerations,topologySpreadConstraints} to alter pod placement. If you prefer to only add a subset of these, like only tolerations was needed in my case, please do inform and I can adjust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: Deploying the new version
2.0.0chart we see the Job/foo-cert-generator pod stuck on pending scheduling when all cluster nodes have taints.Solution: Add the ability to inject
job.spec.template.spec.{affinity,nodeSelector,tolerations,topologySpreadConstraints}to alter pod placement. If you prefer to only add a subset of these, like onlytolerationswas needed in my case, please do inform and I can adjust.Testing: Local
helm templatetesting.Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.