Skip to content

Use double buffers in EventLoop #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 16, 2022
Merged

Use double buffers in EventLoop #270

merged 4 commits into from
Nov 16, 2022

Conversation

@kate-osborn
Copy link
Contributor

@kate-osborn kate-osborn commented Oct 14, 2022

Resolves FIXME:

Making an entirely new buffer is inefficient and multiplies memory operations.
Use a double-buffer approach - create two buffers and exchange them between the producer and consumer
routines. NOTE: pass-by-reference, and reset buffer to length 0, but retain capacity.

@kate-osborn kate-osborn requested a review from a team as a code owner October 14, 2022 21:44
@github-actions github-actions bot added the bug Something isn't working label Oct 14, 2022
pleshakov
pleshakov suggested changes Oct 18, 2022
View reviewed changes
pleshakov
pleshakov approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kate-osborn kate-osborn force-pushed the fix/use-double-buffer branch from e4fb601 to 86b8887 Compare October 21, 2022 16:25
f5yacobucci
f5yacobucci reviewed Nov 3, 2022
View reviewed changes
f5yacobucci
f5yacobucci reviewed Nov 4, 2022
View reviewed changes
@kate-osborn kate-osborn force-pushed the fix/use-double-buffer branch from 86b8887 to 3d39dee Compare November 7, 2022 18:47
@kate-osborn kate-osborn force-pushed the fix/use-double-buffer branch from 3d39dee to ddd584f Compare November 16, 2022 17:25
@kate-osborn kate-osborn merged commit 6520a4d into main Nov 16, 2022
@kate-osborn kate-osborn deleted the fix/use-double-buffer branch November 16, 2022 17:34
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
@miledxz
Use double buffers in EventLoop (nginx#270)
ca00964
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@pleshakov pleshakov pleshakov approved these changes

@f5yacobucci f5yacobucci f5yacobucci approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kate-osborn @pleshakov @f5yacobucci