Skip to content

Conversation

@nginx-bot
Copy link
Contributor

This automated PR updates all the necessary files for 1.4.0 release.

@github-actions github-actions bot added documentation Improvements or additions to documentation helm-chart Relates to helm chart labels Aug 16, 2024
@github-actions
Copy link
Contributor

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-gateway-fabric/2411/

@sjberman sjberman marked this pull request as ready for review August 16, 2024 18:38
@sjberman sjberman requested review from a team as code owners August 16, 2024 18:38
@sjberman
Copy link
Collaborator

@lucacome Does it make sense for this PR to go into main and then be cherry-picked to the release branch? Is there any content here that shouldn't be in the main branch?

Trying to think how we did this in the last release if this automated PR only works for the release branch.

@sjberman
Copy link
Collaborator

I guess the edge changes shouldn't go into main.

@lucacome
Copy link
Contributor

@sjberman yeah everything will point to 1.4.0, but I think that should be our default in the main branch and not edge anyway...

Copy link
Contributor

@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's still merge it to the release branch for this release. We should have a conversation about tags, edge, etc. for the next release.

@sjberman sjberman enabled auto-merge (squash) August 20, 2024 18:22
@sjberman sjberman merged commit 8e653d6 into release-1.4 Aug 20, 2024
@sjberman sjberman deleted the docs/release-1.4.0 branch August 20, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation helm-chart Relates to helm chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants