Check for ReferenceGrants from GRPCRoutes to Services #2337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2337 +/- ##
==========================================
+ Coverage 87.74% 87.77% +0.03%
==========================================
Files 96 96
Lines 6830 6847 +17
Branches 50 50
==========================================
+ Hits 5993 6010 +17
Misses 780 780
Partials 57 57 ☔ View full report in Codecov by Sentry. |
sjberman
approved these changes
Aug 6, 2024
kate-osborn
force-pushed
the
fix/grpcroute-ref-grant
branch
from
3a1dc7b to
3500d5e
Compare
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
Problem: ReferenceGrants that permit GRPCRoutes to reference Services in different namespaces are ignored by NGF, effectively preventing all cross-namespace routing for GRPC traffic. Solution: Check for ReferenceGrants from GRPCRoutes to Services when validating GRPCRoutes. If a ReferenceGrant exists that permits the cross-namespace reference, allow it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: ReferenceGrants that permit GRPCRoutes to reference Services in different namespaces are ignored by NGF., effectively preventing all cross-namespace routing for GRPC traffic.
Solution: Check for ReferenceGrants from GRPCRoutes to Services when validating GRPCRoutes. If a ReferenceGrant exists that permits the cross-namespace reference, allow it.
Testing: Verified that a GRPCRoute that references a Service in a different namespace is allowed if and only if a ReferenceGrant exits for that particular reference.
Closes #2333
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.