Skip to content

Conversation

@lucacome
Copy link
Contributor

@lucacome lucacome commented Jul 31, 2024

Proposed changes

/usr/bin/env bash is more flexible than /bin/bash when using different OSes.
Also found some files and script with wrong permissions.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome lucacome requested a review from a team as a code owner July 31, 2024 03:43
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jul 31, 2024
@codecov
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.76%. Comparing base (f07197c) to head (215ee44).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2315   +/-   ##
=======================================
  Coverage   87.76%   87.76%           
=======================================
  Files          96       96           
  Lines        6793     6793           
  Branches       50       50           
=======================================
  Hits         5962     5962           
  Misses        774      774           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 31, 2024
@sjberman
Copy link
Collaborator

I'm assuming the results markdown files get their permissions from the code that generates them, so we'll probably need to update that as well.

@lucacome
Copy link
Contributor Author

That was updated already with the recent changes to the NFR tests unless I missed something. It’s strange that the edge files still had wrong permissions but maybe it’s because they were created before and an append doesn’t change file permissions?

@lucacome lucacome self-assigned this Jul 31, 2024
@lucacome lucacome enabled auto-merge (squash) July 31, 2024 17:52
@lucacome lucacome merged commit f586309 into nginx:main Jul 31, 2024
@lucacome lucacome deleted the chore/bash branch July 31, 2024 18:24
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
`/usr/bin/env bash` is more flexible than `/bin/bash` when using different OSes.
This also fixes files and script with wrong permissions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants