Skip to content

Conversation

@lucacome
Copy link
Contributor

Proposed changes

Problem: helm-docs wasn't working correctly with pre-commit when we started using it, but now it's fixed

Solution: Add helm-docs to pre-commit now that it works

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

Problem: helm-docs wasn't working correctly with pre-commit when we
started using it, but now it's fixed

Solution: Add helm-docs to pre-commit now that it works
@lucacome lucacome requested a review from a team as a code owner July 11, 2024 19:57
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jul 11, 2024
@codecov
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.62%. Comparing base (6cbb524) to head (dda359d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2230   +/-   ##
=======================================
  Coverage   87.62%   87.62%           
=======================================
  Files          96       96           
  Lines        6715     6715           
  Branches       50       50           
=======================================
  Hits         5884     5884           
  Misses        774      774           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucacome lucacome merged commit efea992 into nginx:main Jul 11, 2024
@lucacome lucacome deleted the chore/pre-commit-helm-docs branch July 11, 2024 20:34
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
Problem: helm-docs wasn't working correctly with pre-commit when we
started using it, but now it's fixed

Solution: Add helm-docs to pre-commit now that it works
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants