Skip to content

Conversation

@lucacome
Copy link
Contributor

Proposed changes

Problem: The single * wasn't matching all possible branch names

Solution: Use globstar to match all kind of names

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

Problem: The single * wasn't matching all possible branch names

Solution: Use globstar to match all kind of names
@lucacome lucacome self-assigned this Jun 27, 2024
@lucacome lucacome requested a review from a team as a code owner June 27, 2024 22:35
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jun 27, 2024
@lucacome lucacome merged commit 7851015 into nginx:main Jun 27, 2024
@lucacome lucacome deleted the chore/run-on-all-branches branch June 27, 2024 23:39
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
Problem: The single * wasn't matching all possible branch names

Solution: Use globstar to match all kind of names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants