Skip to content

Add retries to tracing tests #2101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Add retries to tracing tests #2101

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d32240e
Add retries to tracing tests
sjberman Jun 5, 2024
6990a3b
Merge branch 'main' into tests/flaky-tracing
sjberman Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tests/suite/tracing_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@ import (
"github.com/nginxinc/nginx-gateway-fabric/tests/framework"
)

var _ = Describe("Tracing", Label("functional", "tracing"), func() {
// This test can be flaky when waiting to see traces show up in the collector logs.
// Sometimes they get there right away, sometimes it takes 30 seconds. Retries were
// added to attempt to mitigate the issue, but it didn't fix it 100%
var _ = Describe("Tracing", FlakeAttempts(2), Label("functional", "tracing"), func() {
var (
files = []string{
"hello-world/apps.yaml",
Expand Down