-
Notifications
You must be signed in to change notification settings - Fork 118
Allow NGF to run on Openshift #1976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
09fac66
Add SCC and inclusion of openshift on helm chart
bjee19 622e4c6
Adjust scc range values
bjee19 3503fdc
Fix rbac spacing
bjee19 8362f28
Add Openshift Permissions Reference document
bjee19 68f1a20
Add Openshift Permissions installaiton guide
bjee19 ada3ae0
Adjust wording of SCC
bjee19 9c6e578
Change helm template from onOpenshift to platform
bjee19 2592c87
Change helm template from onOpenshift to platform
bjee19 0c14d2c
Add allowPrivilegeEscalation
bjee19 9727a3b
Remove unnecessary false boolean fields in SCC
bjee19 a36ca2c
Add Helm templating for SCC
bjee19 356c951
Remove openshift permissions document
bjee19 b3b8fc2
Add back required SCC fields
bjee19 fa42453
Add platform openshift to upgrade commands too
bjee19 580cec8
Add sccName value to rbac template
bjee19 892d48a
Add scc name to helpers template file
bjee19 517ac81
Remove sccName from values file
bjee19 202c0c9
Add createOpenShiftSCC flag
bjee19 083972a
Add openshift manifests and helm template generation
bjee19 d32061d
Remove unnecessary scc manifest
bjee19 9b17360
Add installation through manifests on openshift document
bjee19 8834573
Add grpc routes changes from main
bjee19 228de49
Remove running on openshift document
bjee19 f8f97c9
Add openshift to file names and add files to goreleaser
bjee19 48a7e1c
Add Helm template checker for Openshift platform and remove fields in…
bjee19 ad6dacc
Remove openshift specific manifests
bjee19 540552b
Update scc users template to use release namespace and SA name
bjee19 2515c22
Add scc.yaml manifest
bjee19 2e2153f
Remove Openshift manifest specific document
bjee19 2238762
Remove comment on installation in helm installation guide
bjee19 03c8be5
Add more details on installation through manifests
bjee19 bda54b7
Change SCC link to version 1.2.0
bjee19 2573e90
Fix Openshift to OpenShift
bjee19 0dcc8b6
Fix rebase issue
bjee19 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
{{- if .Capabilities.APIVersions.Has "security.openshift.io/v1/SecurityContextConstraints" }} | ||
kind: SecurityContextConstraints | ||
apiVersion: security.openshift.io/v1 | ||
metadata: | ||
name: {{ include "nginx-gateway.scc-name" . }} | ||
allowPrivilegeEscalation: {{ .Values.nginxGateway.securityContext.allowPrivilegeEscalation }} | ||
allowHostDirVolumePlugin: false | ||
allowHostIPC: false | ||
allowHostNetwork: false | ||
allowHostPID: false | ||
allowHostPorts: false | ||
allowPrivilegedContainer: false | ||
readOnlyRootFilesystem: true | ||
runAsUser: | ||
type: MustRunAsRange | ||
uidRangeMin: 101 | ||
uidRangeMax: 102 | ||
fsGroup: | ||
type: MustRunAs | ||
ranges: | ||
- min: 1001 | ||
max: 1001 | ||
supplementalGroups: | ||
type: MustRunAs | ||
ranges: | ||
- min: 1001 | ||
max: 1001 | ||
seLinuxContext: | ||
type: MustRunAs | ||
volumes: | ||
- emptyDir | ||
- secret | ||
users: | ||
- {{ printf "system:serviceaccount:%s:%s" .Release.Namespace (include "nginx-gateway.serviceAccountName" .) }} | ||
allowedCapabilities: | ||
- NET_BIND_SERVICE | ||
- KILL | ||
requiredDropCapabilities: | ||
- ALL | ||
{{- end }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
--- | ||
# Source: nginx-gateway-fabric/templates/scc.yaml | ||
kind: SecurityContextConstraints | ||
apiVersion: security.openshift.io/v1 | ||
metadata: | ||
name: nginx-gateway-scc | ||
allowPrivilegeEscalation: false | ||
allowHostDirVolumePlugin: false | ||
allowHostIPC: false | ||
allowHostNetwork: false | ||
allowHostPID: false | ||
allowHostPorts: false | ||
bjee19 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
allowPrivilegedContainer: false | ||
readOnlyRootFilesystem: true | ||
runAsUser: | ||
type: MustRunAsRange | ||
kate-osborn marked this conversation as resolved.
Show resolved
Hide resolved
|
||
uidRangeMin: 101 | ||
uidRangeMax: 102 | ||
fsGroup: | ||
type: MustRunAs | ||
ranges: | ||
- min: 1001 | ||
max: 1001 | ||
supplementalGroups: | ||
type: MustRunAs | ||
ranges: | ||
- min: 1001 | ||
max: 1001 | ||
seLinuxContext: | ||
type: MustRunAs | ||
kate-osborn marked this conversation as resolved.
Show resolved
Hide resolved
|
||
volumes: | ||
- emptyDir | ||
- secret | ||
users: | ||
- system:serviceaccount:nginx-gateway:nginx-gateway | ||
allowedCapabilities: | ||
- NET_BIND_SERVICE | ||
- KILL | ||
requiredDropCapabilities: | ||
- ALL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.