Skip to content

Add installed architecture to telemetry data #1604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Add installed architecture to telemetry data #1604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions internal/mode/static/telemetry/collector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"context"
"errors"
"fmt"
"runtime"

appsv1 "k8s.io/api/apps/v1"
v1 "k8s.io/api/core/v1"
Expand Down Expand Up @@ -52,6 +53,7 @@ type Data struct {
ProjectMetadata ProjectMetadata
ClusterID string
ImageSource string
Arch string
NGFResourceCounts NGFResourceCounts
NodeCount int
NGFReplicaCount int
Expand Down Expand Up @@ -119,6 +121,7 @@ func (c DataCollectorImpl) Collect(ctx context.Context) (Data, error) {
NGFReplicaCount: ngfReplicaCount,
ClusterID: clusterID,
ImageSource: c.cfg.ImageSource,
Arch: runtime.GOARCH,
}

return data, nil
Expand Down
2 changes: 2 additions & 0 deletions internal/mode/static/telemetry/collector_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"errors"
"fmt"
"reflect"
"runtime"

. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
Expand Down Expand Up @@ -124,6 +125,7 @@ var _ = Describe("Collector", Ordered, func() {
NGFReplicaCount: 1,
ClusterID: string(kubeNamespace.GetUID()),
ImageSource: "local",
Arch: runtime.GOARCH,
}

k8sClientReader = &eventsfakes.FakeReader{}
Expand Down