Make telemetry job a generic runnable #1529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kate-osborn
reviewed
Feb 1, 2024
Contributor
kate-osborn
left a comment
kate-osborn
left a comment
There was a problem hiding this comment.
LGTM, just a couple of small comments.
5 tasks
Problem: Multiple reporting systems need to use the telemetry job, and duplicated code would like to be avoided. Solution: Turn the telemetry job into a generic job that runs a "worker" function, provided by the caller.
sjberman
force-pushed
the
chore/generic-job
branch
from
d9af12c to
edcdfbd
Compare
sjberman
force-pushed
the
chore/generic-job
branch
from
582ad91 to
219d14f
Compare
pleshakov
approved these changes
Feb 1, 2024
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
Problem: Multiple reporting systems need to use the telemetry job, and duplicated code would like to be avoided. Solution: Turn the telemetry job into a generic job that runs a "worker" function, provided by the caller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Multiple reporting systems need to use the telemetry job, and duplicated code would like to be avoided.
Solution: Turn the telemetry job into a generic job that runs a "worker" function, provided by the caller.