[Refactor] Remove the redundant wrapper function createMaps
#1427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function `createMaps` only passes all arguments to `buildAddHeaderMaps`. Hence, `createMaps` is redundant.
kate-osborn
approved these changes
Jan 2, 2024
Contributor
kate-osborn
left a comment
kate-osborn
left a comment
There was a problem hiding this comment.
LGTM!
@kevin85421 can you rewrite your PR to follow the Problem/Solution format in the template? Thanks!
Contributor
Author
|
@kate-osborn Updated. Thanks! |
pleshakov
approved these changes
Jan 3, 2024
sjberman
approved these changes
Jan 3, 2024
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
…1427) The function `createMaps` only passes all arguments to `buildAddHeaderMaps`. Hence, `createMaps` is redundant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: The function
createMapsonly passes all arguments tobuildAddHeaderMaps. Hence,createMapsis redundant.Solution: Remove the function
createMaps, and call the functionbuildAddHeaderMapsdirectly.Testing:
Checklist
Before creating a PR, run through this checklist and mark each as complete.