-
Notifications
You must be signed in to change notification settings - Fork 148
Update nginx-prometheus-exporter to 1.0.0 #1347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kate-osborn
merged 9 commits into
main
from
dependabot/go_modules/github.com/nginxinc/nginx-prometheus-exporter-1.0.0
Jan 8, 2024
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a0c22bd
Bump github.com/nginxinc/nginx-prometheus-exporter from 0.11.0 to 1.0.0
dependabot[bot] 29b7d4b
Update to 1.0 prom exporter
2f630d7
Run go mod tidy
4fb283b
Leveled Prometheus logger
5d601ae
Move fieldErr to updateControlPlane
625edcb
Use errors.Join
fec0736
Add tests
716b088
Validate in updateControlPlane
2023463
Remove return error from NewNginxMetricsCollector
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,133 @@ | ||
| package static | ||
|
|
||
| import ( | ||
| "errors" | ||
| "fmt" | ||
| "testing" | ||
|
|
||
| . "github.com/onsi/gomega" | ||
| "k8s.io/apimachinery/pkg/types" | ||
| "k8s.io/client-go/tools/record" | ||
| "sigs.k8s.io/controller-runtime/pkg/log/zap" | ||
|
|
||
| ngfAPI "github.com/nginxinc/nginx-gateway-fabric/apis/v1alpha1" | ||
| "github.com/nginxinc/nginx-gateway-fabric/internal/framework/helpers" | ||
| "github.com/nginxinc/nginx-gateway-fabric/internal/mode/static/staticfakes" | ||
| ) | ||
|
|
||
| func TestUpdateControlPlane(t *testing.T) { | ||
| debugLogCfg := &ngfAPI.NginxGateway{ | ||
| Spec: ngfAPI.NginxGatewaySpec{ | ||
| Logging: &ngfAPI.Logging{ | ||
| Level: helpers.GetPointer(ngfAPI.ControllerLogLevelDebug), | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| invalidLevelConfig := &ngfAPI.NginxGateway{ | ||
| Spec: ngfAPI.NginxGatewaySpec{ | ||
| Logging: &ngfAPI.Logging{ | ||
| Level: helpers.GetPointer[ngfAPI.ControllerLogLevel]("invalid"), | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| logger := zap.New() | ||
| fakeEventRecorder := record.NewFakeRecorder(1) | ||
| nsname := types.NamespacedName{Namespace: "test", Name: "test"} | ||
|
|
||
| tests := []struct { | ||
| setLevelErr error | ||
| nginxGateway *ngfAPI.NginxGateway | ||
| name string | ||
| expErrString string | ||
| expSetLevelCallCount int | ||
| expEvent bool | ||
| }{ | ||
| { | ||
| name: "change log level", | ||
| nginxGateway: debugLogCfg, | ||
| expSetLevelCallCount: 1, | ||
| }, | ||
| { | ||
| name: "invalid log level", | ||
| nginxGateway: invalidLevelConfig, | ||
| expErrString: `Unsupported value: "invalid"`, | ||
| expSetLevelCallCount: 0, | ||
| }, | ||
| { | ||
| name: "nil NginxGateway", | ||
| nginxGateway: nil, | ||
| expEvent: true, | ||
| expSetLevelCallCount: 1, | ||
| }, | ||
| { | ||
| name: "set log level fails", | ||
| nginxGateway: debugLogCfg, | ||
| setLevelErr: errors.New("set level failed"), | ||
| expErrString: "set level failed", | ||
| expSetLevelCallCount: 1, | ||
| }, | ||
| } | ||
|
|
||
| for _, test := range tests { | ||
| t.Run(test.name, func(t *testing.T) { | ||
| g := NewWithT(t) | ||
|
|
||
| fakeLogSetter := &staticfakes.FakeLogLevelSetter{ | ||
| SetLevelStub: func(s string) error { | ||
| return test.setLevelErr | ||
| }, | ||
| } | ||
|
|
||
| err := updateControlPlane(test.nginxGateway, logger, fakeEventRecorder, nsname, fakeLogSetter) | ||
|
|
||
| if test.expErrString != "" { | ||
| g.Expect(err).To(HaveOccurred()) | ||
| g.Expect(err.Error()).To(ContainSubstring(test.expErrString)) | ||
| } else { | ||
| g.Expect(err).ToNot(HaveOccurred()) | ||
| } | ||
|
|
||
| if test.expEvent { | ||
| g.Expect(fakeEventRecorder.Events).To(HaveLen(1)) | ||
| event := <-fakeEventRecorder.Events | ||
| g.Expect(event).To(ContainSubstring("ResourceDeleted")) | ||
| } else { | ||
| g.Expect(fakeEventRecorder.Events).To(BeEmpty()) | ||
| } | ||
|
|
||
| g.Expect(fakeLogSetter.SetLevelCallCount()).To(Equal(test.expSetLevelCallCount)) | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| func TestValidateLogLevel(t *testing.T) { | ||
| validLevels := []ngfAPI.ControllerLogLevel{ | ||
| ngfAPI.ControllerLogLevelError, | ||
| ngfAPI.ControllerLogLevelInfo, | ||
| ngfAPI.ControllerLogLevelDebug, | ||
| } | ||
|
|
||
| invalidLevels := []ngfAPI.ControllerLogLevel{ | ||
| ngfAPI.ControllerLogLevel("invalid"), | ||
| ngfAPI.ControllerLogLevel("high"), | ||
| ngfAPI.ControllerLogLevel("warn"), | ||
| } | ||
|
|
||
| for _, level := range validLevels { | ||
| t.Run(fmt.Sprintf("valid level %q", level), func(t *testing.T) { | ||
| g := NewWithT(t) | ||
|
|
||
| g.Expect(validateLogLevel(level)).To(Succeed()) | ||
| }) | ||
| } | ||
|
|
||
| for _, level := range invalidLevels { | ||
| t.Run(fmt.Sprintf("invalid level %q", level), func(t *testing.T) { | ||
| g := NewWithT(t) | ||
|
|
||
| g.Expect(validateLogLevel(level)).ToNot(Succeed()) | ||
| }) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.