Use new types to process resource changes #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kate-osborn
suggested changes
Jun 9, 2022
Contributor
kate-osborn
left a comment
kate-osborn
left a comment
There was a problem hiding this comment.
Looks good! Just a few minor comments/questions
Contributor
There was a problem hiding this comment.
I think we should add the expected ns name to this log so the user has the ability to fix the error.
Contributor
Author
There was a problem hiding this comment.
I don't think this always will be an error though. Because let's say the admin deploys multiple NGINX Gateways, each watching its own Gateway resources.
Contributor
There was a problem hiding this comment.
True. Once we support configurable gateway names we can change this back.
pleshakov
force-pushed
the
feature/listeners-config-gen
branch
from
a3df36f to
107c3e3
Compare
This commit plugs in the new types introduced in 0a39e3f to process changes to resources and generate NGINX configuration.
pleshakov
force-pushed
the
feature/listeners-config-gen
branch
from
107c3e3 to
6ba113d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR plugs in the new types introduced in #121 to process
changes to resources and generate NGINX configuration.
The installation manifests and examples were also updated to support the Gateway resource.
Note: the status updating was removed. In will be reintroduced in the next PR -- an updated version what works with the new types.