-
Notifications
You must be signed in to change notification settings - Fork 136
Closed
Labels
area/performancePerformance relatedPerformance relatedbacklogCurrently unprioritized work. May change with user feedback or as the product progresses.Currently unprioritized work. May change with user feedback or as the product progresses.bugSomething isn't workingSomething isn't working
Description
Describe the bug
We are reloading after reconciling a HTTPRoute even when there is no accepted Gateway and no config being generated.
To Reproduce
Steps to reproduce the behavior:
Deploy a HTTPRoute referring to a Gateway that has not yet been created. Observe that NGINX config files are being regenerated and NGINX is reloaded.
Expected behavior
NGINX should not be reloaded when no NGINX config changes have occurred. In this specific case, without any accepted Gateway, we do not write anything new to the http.conf
file, meaning there are no changes to be reloaded.
Your environment
GKE cluster:
- Node count: 3
- Instance Type: e2-medium
- k8s version: 1.27.4-gke.900
- Zone: europe-west2-b
- Total vCPUs: 6
- Total RAM: 12GB
- Max pods per node: 110
NGF deployment:
- NGF version: edge - git commit 72b6c6e
- NGINX Version: 1.25.2
Additional context
See #1116
Metadata
Metadata
Assignees
Labels
area/performancePerformance relatedPerformance relatedbacklogCurrently unprioritized work. May change with user feedback or as the product progresses.Currently unprioritized work. May change with user feedback or as the product progresses.bugSomething isn't workingSomething isn't working
Type
Projects
Status
✅ Done