Revert parentRefIndex

Author: bjee19

internal/controller/state/graph/route_common.go

@@ -294,9 +294,7 @@ func buildSectionNameRefs(
 		return nil
 	}
 
-	parentRefIndex := 0
-
-	for _, p := range parentRefs {
+	for i, p := range parentRefs {
 		gw := findGatewayForParentRef(p, routeNamespace, gws)
 		if gw == nil {
 			continue
@@ -317,17 +315,16 @@ func buildSectionNameRefs(
 				}
 
 				sectionNameRefs = append(sectionNameRefs, ParentRef{
-					Idx:         parentRefIndex,
+					// if the ParentRefs we create are for each listener in the same gateway, we keep the
+					// parentRefIndex the same so when we look at a route's parentRef's we can see
+					// if the parentRef is a unique parentRef or one we created internally
+					Idx:         i,
 					Gateway:     CreateParentRefGateway(gw),
 					SectionName: &l.Source.Name,
 					Port:        p.Port,
 				})
 			}
 
-			// if the ParentRefs we create are for each listener in the same gateway, we keep the
-			// parentRefIndex the same so when we look at a route's parentRef's we can see
-			// if the parentRef is a unique parentRef or one we created internally
-			parentRefIndex++
 			continue
 		}
 
@@ -337,12 +334,11 @@ func buildSectionNameRefs(
 		}
 
 		sectionNameRefs = append(sectionNameRefs, ParentRef{
-			Idx:         parentRefIndex,
+			Idx:         i,
 			Gateway:     CreateParentRefGateway(gw),
 			SectionName: p.SectionName,
 			Port:        p.Port,
 		})
-		parentRefIndex++
 	}
 
 	return sectionNameRefs, nil

internal/controller/state/graph/route_common_test.go

@@ -104,27 +104,27 @@ func TestBuildSectionNameRefs(t *testing.T) {
 			SectionName: parentRefs[0].SectionName,
 		},
 		{
-			Idx:         1,
+			Idx:         2,
 			Gateway:     CreateParentRefGateway(gws[gwNsName2]),
 			SectionName: parentRefs[2].SectionName,
 		},
 		{
-			Idx:         2,
+			Idx:         3,
 			Gateway:     CreateParentRefGateway(gws[gwNsName1]),
 			SectionName: parentRefs[3].SectionName,
 		},
 		{
-			Idx:         3,
+			Idx:         4,
 			Gateway:     CreateParentRefGateway(gws[gwNsName2]),
 			SectionName: parentRefs[4].SectionName,
 		},
 		{
-			Idx:         4,
+			Idx:         6,
 			Gateway:     CreateParentRefGateway(gws[gwNsName3]),
 			SectionName: helpers.GetPointer[gatewayv1.SectionName]("http"),
 		},
 		{
-			Idx:         4,
+			Idx:         6,
 			Gateway:     CreateParentRefGateway(gws[gwNsName3]),
 			SectionName: helpers.GetPointer[gatewayv1.SectionName]("https"),
 		},