Fix conformance test

Author: bjee19

internal/controller/status/prepare_requests.go

@@ -98,29 +98,36 @@ func PrepareRouteRequests(
 // removeDuplicateIndexParentRefs removes duplicate ParentRefs by Idx, keeping the first occurrence.
 // If an Idx is duplicated, the SectionName for the stored ParentRef is nil.
 func removeDuplicateIndexParentRefs(parentRefs []graph.ParentRef) []graph.ParentRef {
-	idxCount := make(map[int]int)
+	idxToParentRef := make(map[int][]graph.ParentRef)
 	for _, ref := range parentRefs {
-		idxCount[ref.Idx]++
+		idxToParentRef[ref.Idx] = append(idxToParentRef[ref.Idx], ref)
 	}
 
-	seen := make(map[int]bool)
-	result := make([]graph.ParentRef, 0, len(parentRefs))
+	results := make([]graph.ParentRef, len(idxToParentRef))
 
-	for _, ref := range parentRefs {
-		if seen[ref.Idx] {
-			continue // skip duplicates
+	for idx, refs := range idxToParentRef {
+		if len(refs) == 1 {
+			results[idx] = refs[0]
+			continue
 		}
-		seen[ref.Idx] = true
 
-		// If this Idx was duplicated, clear SectionName
-		if idxCount[ref.Idx] > 1 {
-			ref.SectionName = nil
+		winningParentRef := graph.ParentRef{
+			Idx:        idx,
+			Gateway:    refs[0].Gateway,
+			Attachment: refs[0].Attachment,
 		}
 
-		result = append(result, ref)
+		for _, ref := range refs {
+			if ref.Attachment.Attached {
+				if len(ref.Attachment.FailedConditions) == 0 || winningParentRef.Attachment == nil {
+					winningParentRef.Attachment = ref.Attachment
+				}
+			}
+		}
+		results[idx] = winningParentRef
 	}
 
-	return result
+	return results
 }
 
 func prepareRouteStatus(

internal/controller/status/prepare_requests_test.go

@@ -78,6 +78,15 @@ var (
 			{
 				SectionName: helpers.GetPointer[v1.SectionName]("listener-443-2"),
 			},
+			{
+				SectionName: helpers.GetPointer[v1.SectionName]("listener-443-3"),
+			},
+			{
+				SectionName: helpers.GetPointer[v1.SectionName]("listener-8080-1"),
+			},
+			{
+				SectionName: helpers.GetPointer[v1.SectionName]("listener-8080-2"),
+			},
 		},
 	}
 
@@ -121,7 +130,8 @@ var (
 			Gateway:     &graph.ParentRefGateway{NamespacedName: gwNsName},
 			SectionName: commonRouteSpecValid.ParentRefs[3].SectionName,
 			Attachment: &graph.ParentRefAttachmentStatus{
-				Attached: true,
+				Attached:         false,
+				FailedConditions: []conditions.Condition{invalidAttachmentCondition},
 			},
 		},
 		{
@@ -132,6 +142,33 @@ var (
 				Attached: true,
 			},
 		},
+		{
+			Idx:         3,
+			Gateway:     &graph.ParentRefGateway{NamespacedName: gwNsName},
+			SectionName: commonRouteSpecValid.ParentRefs[5].SectionName,
+			Attachment: &graph.ParentRefAttachmentStatus{
+				Attached:         true,
+				FailedConditions: []conditions.Condition{invalidAttachmentCondition},
+			},
+		},
+		{
+			Idx:         4,
+			Gateway:     &graph.ParentRefGateway{NamespacedName: gwNsName},
+			SectionName: commonRouteSpecValid.ParentRefs[6].SectionName,
+			Attachment: &graph.ParentRefAttachmentStatus{
+				Attached:         false,
+				FailedConditions: []conditions.Condition{invalidAttachmentCondition},
+			},
+		},
+		{
+			Idx:         4,
+			Gateway:     &graph.ParentRefGateway{NamespacedName: gwNsName},
+			SectionName: commonRouteSpecValid.ParentRefs[7].SectionName,
+			Attachment: &graph.ParentRefAttachmentStatus{
+				Attached:         false,
+				FailedConditions: []conditions.Condition{invalidAttachmentCondition},
+			},
+		},
 	}
 
 	parentRefsInvalid = []graph.ParentRef{
@@ -260,6 +297,37 @@ var (
 					},
 				},
 			},
+			{
+				ParentRef: v1.ParentReference{
+					Namespace: helpers.GetPointer(v1.Namespace(gwNsName.Namespace)),
+					Name:      v1.ObjectName(gwNsName.Name),
+				},
+				ControllerName: gatewayCtlrName,
+				Conditions: []metav1.Condition{
+					{
+						Type:               string(v1.RouteConditionAccepted),
+						Status:             metav1.ConditionTrue,
+						ObservedGeneration: 3,
+						LastTransitionTime: transitionTime,
+						Reason:             string(v1.RouteReasonAccepted),
+						Message:            "The route is accepted",
+					},
+					{
+						Type:               string(v1.RouteConditionResolvedRefs),
+						Status:             metav1.ConditionTrue,
+						ObservedGeneration: 3,
+						LastTransitionTime: transitionTime,
+						Reason:             string(v1.RouteReasonResolvedRefs),
+						Message:            "All references are resolved",
+					},
+					{
+						Type:               invalidAttachmentCondition.Type,
+						Status:             metav1.ConditionTrue,
+						ObservedGeneration: 3,
+						LastTransitionTime: transitionTime,
+					},
+				},
+			},
 		},
 	}