Skip to content

Wrap oidc fclo initiated test in a while loop #8460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
javorszky merged 4 commits into from
Oct 23, 2025
Merged

Wrap oidc fclo initiated test in a while loop #8460

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2d2969a
Wrap oidc fclo initiated test in a while loop
javorszky Oct 23, 2025
932cf7b
Merge branch 'main' into fix/7781-pytest-flake
vepatel Oct 23, 2025
cfe980e
Implement copilot suggestions
javorszky Oct 23, 2025
341727a
Merge branch 'main' into fix/7781-pytest-flake
javorszky Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions tests/suite/test_oidc_fclo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,19 +193,30 @@ def test_oidc(
kube_apis.v1, ingress_controller_prerequisites.namespace, "nginx-ingress-"
)

logs = kube_apis.v1.read_namespaced_pod_log(nic_pod_name, ingress_controller_prerequisites.namespace)
retry = 0
count_fclo_initiated = 0
logs = ""
expected_fclo_count = 2
while count_fclo_initiated != expected_fclo_count and retry < 10:
wait_before_test(1) # wait one second before retrying

count_get_fclo = logs.count("GET /front_channel_logout?sid=")
count_fclo_initiated = logs.count("OIDC Front-Channel Logout initiated for sid:")
logs = kube_apis.v1.read_namespaced_pod_log(nic_pod_name, ingress_controller_prerequisites.namespace)

assert (
count_get_fclo == 2
), f"nginx-ingress logs do not contain GET /front_channel_logout?sid= twice, got {count_get_fclo}"
count_fclo_initiated = logs.count("OIDC Front-Channel Logout initiated for sid:")

print(f"OIDC FCLO Initiated count in the while loop: {count_fclo_initiated}, retrying... {retry}")
retry += 1

assert (
count_fclo_initiated == 2
count_fclo_initiated == expected_fclo_count
), f"nginx-ingress logs do not contain OIDC Front-Channel Logout initiated for sid twice, got {count_fclo_initiated}"

count_get_fclo = logs.count("GET /front_channel_logout?sid=")

assert (
count_get_fclo == expected_fclo_count
), f"nginx-ingress logs do not contain GET /front_channel_logout?sid= twice, got {count_get_fclo}"

delete_secret(kube_apis.v1, secret_one_name, test_namespace)
delete_secret(kube_apis.v1, secret_two_name, test_namespace)
delete_policy(kube_apis.custom_objects, pol_one, test_namespace)
Expand Down