Skip to content

add globalConfigurationCustomName parameter #8142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Aug 27, 2025
Merged

add globalConfigurationCustomName parameter #8142

merged 27 commits into from
Aug 27, 2025

Conversation

mohamadaldawamnah
Copy link
Contributor

@mohamadaldawamnah mohamadaldawamnah commented Aug 14, 2025 •
edited by vepatel
Loading

Proposed changes

  • Added support for globalConfiguration CustomName parameter as submitted by community member @frantsao

PR: #6679

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@mohamadaldawamnah mohamadaldawamnah requested a review from a team as a code owner August 14, 2025 16:40
@github-actions github-actions bot added the enhancement Pull requests for new features/feature enhancements label Aug 14, 2025
@vepatel vepatel changed the title Feature/global config custom name validation add globalConfigurationCustomName parameter Aug 14, 2025
@vepatel vepatel linked an issue Aug 14, 2025 that may be closed by this pull request
GlobalConfiguration custom name in helm chart #6679
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 14, 2025 •
edited
Loading

Package Report

gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx, 1.29.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-module-njs, 1.29.1+0.9.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-module-otel, 1.29.1+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-agent, 3.2.1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx, 1.29.1-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-module-njs, 1.29.1+0.9.1-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-module-otel, 1.29.1+0.1.2-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-agent, 3.2.1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus, 35-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-njs, 35+0.9.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-otel, 35+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-fips-check, 35+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-agent, 3.2.1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus, 35-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-njs, 35+0.9.1-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-otel, 35+0.1.2-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-fips-check, 35+0.1-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-agent, 3.2.1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus, 35-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-njs, 35+0.9.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-otel, 35+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-fips-check, 35+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-appprotect, 35+5.498.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, app-protect, 35+5.498.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, app-protect-attack-signatures, 2025.08.07-2~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, app-protect-threat-campaigns, 2025.08.11-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-agent, 2.42.1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus, 35-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-njs, 35+0.9.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-otel, 35+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-fips-check, 35+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-appprotect, 35+5.498.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, app-protect-module-plus, 35+5.498.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, app-protect-plugin, 6.20.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-agent, 2.42.1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus, 35-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-njs, 35+0.9.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-otel, 35+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-fips-check, 35+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-appprotectdos, 35+4.7.3-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, app-protect-dos, 35+4.7.3-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus, 35-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-njs, 35+0.9.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-otel, 35+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-fips-check, 35+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-appprotect, 35+5.498.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, app-protect, 35+5.498.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, app-protect-attack-signatures, 2025.08.07-2~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, app-protect-threat-campaigns, 2025.08.11-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-plus-module-appprotectdos, 35+4.7.3-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, app-protect-dos, 35+4.7.3-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06, nginx-agent, 2.42.1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx, 1.29.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx-module-njs, 1.29.1.0.9.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx-module-otel, 1.29.1.0.1.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx-agent, 3.2.1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx, 1.29.1-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx-module-njs, 1.29.1.0.9.1-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx-module-otel, 1.29.1.0.1.2-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx-agent, 3.2.1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx-plus, 35-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx-plus-module-njs, 35.0.9.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx-plus-module-otel, 35.0.1.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx-plus-module-fips-check, 35.0.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx-agent, 3.2.1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx-plus, 35-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx-plus-module-njs, 35.0.9.1-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx-plus-module-otel, 35.0.1.2-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx-plus-module-fips-check, 35.0.1-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine, nginx-agent, 3.2.1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus, 35-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus-module-njs, 35.0.9.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus-module-otel, 35.0.1.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus-module-fips-check, 35.0.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-agent, 3.2.1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus, 35-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus-module-njs, 35.0.9.1-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus-module-otel, 35.0.1.2-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus-module-fips-check, 35.0.1-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-agent, 3.2.1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus, 35-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus-module-njs, 35.0.9.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus-module-otel, 35.0.1.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus-module-fips-check, 35.0.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-agent, 2.42.1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus-module-appprotect, 35.5.498.0-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, app-protect, 35.5.498.0-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, app-protect-attack-signatures, 2025.08.07-r2, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, app-protect-threat-campaigns, 2025.08.11-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus, 35-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus-module-njs, 35.0.9.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus-module-otel, 35.0.1.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus-module-fips-check, 35.0.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-agent, 2.42.1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, nginx-plus-module-appprotect, 35.5.498.0-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, app-protect-module-plus, 35.5.498.0-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-alpine-fips, app-protect-plugin, 6.20.0-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx, 1.29.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-module-njs, 1.29.1+0.9.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-module-otel, 1.29.1+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-agent, 3.2.1-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx, 1.29.1-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-module-njs, 1.29.1+0.9.1-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-module-otel, 1.29.1+0.1.2-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-agent, 3.2.1-1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus, 35-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-njs, 35+0.9.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-otel, 35+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-fips-check, 35+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-agent, 3.2.1-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus, 35-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-njs, 35+0.9.1-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-otel, 35+0.1.2-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-fips-check, 35+0.1-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-agent, 3.2.1-1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus, 35-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-njs, 35+0.9.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-otel, 35+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-fips-check, 35+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-agent, 2.42.1-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-appprotect, 35+5.498.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, app-protect, 35+5.498.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, app-protect-attack-signatures, 2025.08.07-2.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, app-protect-threat-campaigns, 2025.08.11-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus, 35-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-njs, 35+0.9.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-otel, 35+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-fips-check, 35+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-agent, 2.42.1-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-appprotect, 35+5.498.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, app-protect-module-plus, 35+5.498.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, app-protect-plugin, 6.20.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi8, nginx-plus, 35-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi8, nginx-plus-module-njs, 35+0.9.1-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi8, nginx-plus-module-otel, 35+0.1.2-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi8, nginx-plus-module-fips-check, 35+0.1-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi8, nginx-agent, 2.42.1-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi8, nginx-plus-module-appprotect, 35+5.498.0-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi8, app-protect, 35+5.498.0-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi8, app-protect-attack-signatures, 2025.08.07-2.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi8, app-protect-threat-campaigns, 2025.08.11-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi8, nginx-plus, 35-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi8, nginx-plus-module-njs, 35+0.9.1-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi8, nginx-plus-module-otel, 35+0.1.2-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi8, nginx-plus-module-fips-check, 35+0.1-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi8, nginx-agent, 2.42.1-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi8, nginx-plus-module-appprotect, 35+5.498.0-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi8, app-protect-module-plus, 35+5.498.0-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi8, app-protect-plugin, 6.20.0-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus, 35-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-njs, 35+0.9.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-otel, 35+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-fips-check, 35+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-appprotectdos, 35+4.7.3-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, app-protect-dos, 35+4.7.3-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus, 35-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-njs, 35+0.9.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-otel, 35+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-fips-check, 35+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-appprotect, 35+5.498.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-plus-module-appprotectdos, 35+4.7.3-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, nginx-agent, 2.42.1-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, app-protect, 35+5.498.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, app-protect-attack-signatures, 2025.08.07-2.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, app-protect-threat-campaigns, 2025.08.11-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-19b3060bc98314a777ee754406f2ff06-ubi, app-protect-dos, 35+4.7.3-1.el9.ngx, x86_64

@danielnginx danielnginx requested a review from Copilot August 14, 2025 16:53
Copilot

This comment was marked as outdated.

Sign in to view

@vepatel
Copy link
Contributor

vepatel commented Aug 15, 2025 •
edited
Loading

Update: https://github.com/nginx/kubernetes-ingress/tree/feature/global-config-custom-name-validation/charts/tests/testdata and https://github.com/nginx/kubernetes-ingress/blob/feature/global-config-custom-name-validation/charts/tests/helmunit_test.go with new test for custom name.

can use:

@github-actions github-actions bot added the go Pull requests that update Go code label Aug 15, 2025
@codecov Codecov
Copy link

codecov bot commented Aug 15, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.33%. Comparing base (6b5ea85) to head (bf20392).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8142      +/-   ##
==========================================
- Coverage   53.36%   53.33%   -0.03%     
==========================================
  Files          90       90              
  Lines       21912    21912              
==========================================
- Hits        11693    11687       -6     
- Misses       9742     9746       +4     
- Partials      477      479       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

This comment was marked as outdated.

Sign in to view

Copilot

This comment was marked as outdated.

Sign in to view

Copilot

This comment was marked as outdated.

Sign in to view

Copilot

This comment was marked as outdated.

Sign in to view

@danielnginx danielnginx requested a review from Copilot August 18, 2025 13:44
Copilot
Copilot AI reviewed Aug 18, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for a globalConfiguration.customName parameter that allows users to specify a custom namespace and name for the GlobalConfiguration custom resource instead of using the default generated name.

  • Adds customName parameter to values.yaml with validation logic
  • Updates Helm templates to use the custom name when provided
  • Includes comprehensive test coverage for valid and invalid custom name formats

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
charts/nginx-ingress/values.yaml Adds the new customName parameter with documentation
charts/nginx-ingress/values.schema.json Defines JSON schema for the new customName field
charts/nginx-ingress/templates/_helpers.tpl Implements validation and parsing logic for custom names
charts/nginx-ingress/templates/controller-globalconfiguration.yaml Updates template to use custom name when provided
charts/tests/helmunit_test.go Adds test cases for valid and invalid custom name scenarios
charts/tests/testdata/*.yaml Test data files for various custom name scenarios
charts/tests/snapshots/helmunit_test.snap Expected test outputs for the new functionality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

AlexFenlon
AlexFenlon previously approved these changes Aug 21, 2025
View reviewed changes
haywoodsh
haywoodsh previously approved these changes Aug 25, 2025
View reviewed changes
@mohamadaldawamnah mohamadaldawamnah enabled auto-merge (squash) August 25, 2025 14:55
@mohamadaldawamnah mohamadaldawamnah dismissed stale reviews from haywoodsh and AlexFenlon via c8cf19e August 27, 2025 08:07
@mohamadaldawamnah mohamadaldawamnah force-pushed the feature/global-config-custom-name-validation branch from 1e60ac2 to c8cf19e Compare August 27, 2025 08:07
frantsao and others added 15 commits August 27, 2025 09:09
@frantsao @mohamadaldawamnah
Helm: add globalConfigurationCustomName parameter
a73f946 
 Fix documentation in values.yaml (#6679)
@mohamadaldawamnah
adding validation and testing for global conifugration submitted by c…
089e37d 
…ommunity member , added some changes
@mohamadaldawamnah
add global configuration customName tests
4218155
@mohamadaldawamnah
add snapshot file for testing customnames
5d4556e
@mohamadaldawamnah @Copilot
Update charts/nginx-ingress/templates/_helpers.tpl
c042083 
Co-authored-by: Copilot <[email protected]>
Signed-off-by: mohamad_al <[email protected]>
@mohamadaldawamnah @Copilot
Update charts/nginx-ingress/templates/_helpers.tpl
8cf9e2e 
Co-authored-by: Copilot <[email protected]>
Signed-off-by: mohamad_al <[email protected]>
@mohamadaldawamnah
resolving issues mentioned by github copilot
a7b308c
@mohamadaldawamnah
resolving issues mentioned by github copilot
7907d46
@mohamadaldawamnah
fixing linting format
ff4cef0
@mohamadaldawamnah
changing If statment and making sure it can be reached
5376dd5
@mohamadaldawamnah @Copilot
Update charts/nginx-ingress/templates/_helpers.tpl
0aed68b 
Co-authored-by: Copilot <[email protected]>
Signed-off-by: mohamad_al <[email protected]>
@mohamadaldawamnah @Copilot
Update charts/nginx-ingress/templates/_helpers.tpl
fb8f8dd 
Co-authored-by: Copilot <[email protected]>
Signed-off-by: mohamad_al <[email protected]>
@mohamadaldawamnah
fixing copilot mentioned error
69c4789
@mohamadaldawamnah @Copilot
Update charts/nginx-ingress/templates/_helpers.tpl
7f6203a 
Co-authored-by: Copilot <[email protected]>
Signed-off-by: mohamad_al <[email protected]>
@mohamadaldawamnah
fixing copilot mentioned error
3f242c3
@mohamadaldawamnah mohamadaldawamnah force-pushed the feature/global-config-custom-name-validation branch from c8cf19e to 3f242c3 Compare August 27, 2025 08:11
AlexFenlon
AlexFenlon previously approved these changes Aug 27, 2025
View reviewed changes
@mohamadaldawamnah mohamadaldawamnah merged commit 1db0da2 into main Aug 27, 2025
32 checks passed
@mohamadaldawamnah mohamadaldawamnah deleted the feature/global-config-custom-name-validation branch August 27, 2025 17:10
@danielnginx danielnginx mentioned this pull request Sep 2, 2025
Closed
6 tasks
AlexFenlon pushed a commit that referenced this pull request Sep 9, 2025
@mohamadaldawamnah @AlexFenlon
add globalConfigurationCustomName parameter (#8142)
071aebb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@haywoodsh haywoodsh haywoodsh approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

Assignees
No one assigned
Labels
enhancement Pull requests for new features/feature enhancements go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GlobalConfiguration custom name in helm chart
5 participants
@mohamadaldawamnah @vepatel @haywoodsh @AlexFenlon @frantsao