Skip to content

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented May 7, 2025

Proposed changes

  • Update content of "About" based on doc feedback

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner May 7, 2025 12:08
@vepatel vepatel added the documentation Pull requests/issues for documentation label May 7, 2025
@vepatel vepatel requested a review from a team as a code owner May 7, 2025 12:08
@vepatel vepatel added the needs cherry pick Cherry pick this PR into a release branch label May 7, 2025
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vepatel vepatel enabled auto-merge (squash) May 7, 2025 12:11
Copy link
Contributor

github-actions bot commented May 7, 2025

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/7755/

@vepatel vepatel disabled auto-merge May 7, 2025 12:11
@vepatel vepatel enabled auto-merge (squash) May 7, 2025 13:08
Copy link

codecov bot commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.34%. Comparing base (f4ed950) to head (7ffbb61).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7755   +/-   ##
=======================================
  Coverage   52.34%   52.34%           
=======================================
  Files          89       89           
  Lines       21373    21373           
=======================================
  Hits        11188    11188           
  Misses       9719     9719           
  Partials      466      466           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vepatel vepatel merged commit 7a08860 into main May 7, 2025
46 of 61 checks passed
@vepatel vepatel deleted the docs/update-about-nginx branch May 7, 2025 13:20
nginx-bot pushed a commit that referenced this pull request May 7, 2025
haywoodsh pushed a commit that referenced this pull request May 15, 2025
@AlexFenlon AlexFenlon changed the title update NIC about page Update NIC about page Jun 23, 2025
@AlexFenlon AlexFenlon removed the needs cherry pick Cherry pick this PR into a release branch label Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants