-
Notifications
You must be signed in to change notification settings - Fork 2k
Update NIC about page #7755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update NIC about page #7755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADubhlaoich
approved these changes
May 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✅ Deploy Preview will be available once build job completes!
|
danielnginx
approved these changes
May 7, 2025
AlexFenlon
approved these changes
May 7, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7755 +/- ##
=======================================
Coverage 52.34% 52.34%
=======================================
Files 89 89
Lines 21373 21373
=======================================
Hits 11188 11188
Misses 9719 9719
Partials 466 466 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nginx-bot
pushed a commit
that referenced
this pull request
May 7, 2025
haywoodsh
pushed a commit
that referenced
this pull request
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Checklist
Before creating a PR, run through this checklist and mark each as complete.