Skip to content

Make markers strict, and add project.toml to local python tests, #5911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2024
Merged

Make markers strict, and add project.toml to local python tests, #5911

merged 2 commits into from
Jul 2, 2024

Conversation

j1m-ryan
Copy link

@j1m-ryan j1m-ryan commented Jul 2, 2024

Proposed changes

  • Add missing markers to pyproject.toml
  • Make markers strict
  • Fix some marker typos
  • Mount pyproject.toml to local python container

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@j1m-ryan j1m-ryan requested a review from a team as a code owner July 2, 2024 08:28
@github-actions github-actions bot added python Pull requests that update Python code chore Pull requests for routine tasks tests Pull requests that update tests labels Jul 2, 2024
@j1m-ryan j1m-ryan merged commit 0e9ac15 into main Jul 2, 2024
@j1m-ryan j1m-ryan deleted the chore/add-strict-markers-to-pyproject-toml branch July 2, 2024 10:15
@pdabelf5 pdabelf5 changed the title make markers strict, and add project.toml to local python tests, Make markers strict, and add project.toml to local python tests, Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

+2 more reviewers

@oseoin oseoin oseoin approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
chore Pull requests for routine tasks python Pull requests that update Python code tests Pull requests that update tests
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@j1m-ryan @oseoin @vepatel @AlexFenlon @shaun-nx