Skip to content

Change always references to not cancelled #5898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2024
Merged

Change always references to not cancelled #5898

merged 2 commits into from
Jul 1, 2024

Conversation

oseoin
Copy link
Contributor

@oseoin oseoin commented Jul 1, 2024

Proposed changes

This means that we do not try to run the job if a new job replaces the current one.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@oseoin oseoin requested a review from a team as a code owner July 1, 2024 09:49
@github-actions github-actions bot added github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels Jul 1, 2024
@oseoin oseoin enabled auto-merge (squash) July 1, 2024 09:56
@oseoin oseoin merged commit ee25a83 into main Jul 1, 2024
@oseoin oseoin deleted the remove-always-ci branch July 1, 2024 10:20
AlexFenlon pushed a commit that referenced this pull request Jul 1, 2024
@oseoin @AlexFenlon
Change always references to not cancelled (#5898)
19c39a1
@AlexFenlon AlexFenlon mentioned this pull request Jul 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haywoodsh haywoodsh haywoodsh approved these changes

@vepatel vepatel vepatel approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

+1 more reviewer

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
chore Pull requests for routine tasks github_actions Pull requests that update Github_actions code
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oseoin @haywoodsh @vepatel @jjngx @pdabelf5