Skip to content

Update helm docs with serviceNameOverride #4334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2023
Merged

Update helm docs with serviceNameOverride #4334

merged 1 commit into from
Sep 12, 2023

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Sep 11, 2023 •
edited
Loading

Proposed changes

  • Update helm arg table with serviceNameOverride.
  • Fix usage from --set controller.serviceNameOverride to --set serviceNameOverride in upgrade section.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested review from a team as code owners September 11, 2023 09:57
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Sep 11, 2023
@vepatel vepatel linked an issue Sep 11, 2023 that may be closed by this pull request
Add serviceNameOverride to docs #4314
Closed
@vepatel vepatel requested a review from ADubhlaoich September 11, 2023 11:31
ADubhlaoich
ADubhlaoich approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vepatel vepatel merged commit 5b1d085 into main Sep 12, 2023
@vepatel vepatel deleted the docs/serviceNameOverride-helm branch September 12, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@jasonwilliams14 jasonwilliams14 Awaiting requested review from jasonwilliams14

+1 more reviewer

@shaun-nx shaun-nx shaun-nx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Pull requests/issues for documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add serviceNameOverride to docs

3 participants

@vepatel @ADubhlaoich @shaun-nx