Skip to content

Update example spec comment for GlobalConfiguration in helm values.yaml #4285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 28, 2023
Merged

Update example spec comment for GlobalConfiguration in helm values.yaml #4285

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4abb36e
Update example spec comment for GlobalConfiguration in helm values.yaml
shaun-nx Aug 23, 2023
a7054ce
Fir comment indentation
shaun-nx Aug 23, 2023
c742277
Merge branch 'main' into chore/helm-values-gc-comment
shaun-nx Aug 23, 2023
61883cc
Inform users to remove curly brackets when using YAML notation
shaun-nx Aug 24, 2023
550ba66
Merge branch 'main' into chore/helm-values-gc-comment
shaun-nx Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions deployments/helm-chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,14 +271,20 @@ controller:
create: false

## The spec of the GlobalConfiguration for defining the global configuration parameters of the Ingress Controller.
spec: {}
# listeners:
# - name: dns-udp
# port: 5353
# protocol: UDP
# - name: dns-tcp
# port: 5353
# protocol: TCP
spec: {
# "listeners": [
# {
# "name": "dns-udp",
# "port": 5353,
# "protocol": "UDP"
# },
# {
# "name": "dns-tcp",
# "port": 5353,
# "protocol": "TCP"
# }
# ]
}

## Enable custom NGINX configuration snippets in Ingress, VirtualServer, VirtualServerRoute and TransportServer resources.
enableSnippets: false
Expand Down