Skip to content

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Aug 15, 2023

Proposed changes

Update documentation and add examples of how to use Master-Minion Ingresses with path-regex annotation.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested review from a team as code owners August 15, 2023 12:08
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Aug 15, 2023
@jjngx jjngx requested a review from vepatel August 15, 2023 12:09
@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2023

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #4235 (3e527e1) into main (cba845e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4235   +/-   ##
=======================================
  Coverage   51.97%   51.97%           
=======================================
  Files          59       59           
  Lines       16762    16762           
=======================================
  Hits         8712     8712           
  Misses       7753     7753           
  Partials      297      297           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jjngx jjngx linked an issue Aug 15, 2023 that may be closed by this pull request
@jjngx jjngx self-assigned this Aug 15, 2023
@jjngx jjngx merged commit a820492 into main Aug 15, 2023
@jjngx jjngx deleted the docs/path-regex branch August 15, 2023 13:19
Copy link
Collaborator

@brianehlert brianehlert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests/issues for documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update documentation for Ingress Master - Minion

4 participants