Skip to content

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Aug 14, 2023

Proposed changes

This PR introduces following changes to Ingress Master - Minion annotation nginx.org/path-regex:

  • annotation nginx.org/path-regex set on master has no effect on paths specified on minions

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner August 14, 2023 17:45
@github-actions github-actions bot added the enhancement Pull requests for new features/feature enhancements label Aug 14, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2023

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #4223 (cea66d4) into main (db553b0) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4223      +/-   ##
==========================================
- Coverage   51.96%   51.95%   -0.02%     
==========================================
  Files          59       59              
  Lines       16759    16762       +3     
==========================================
- Hits         8709     8708       -1     
- Misses       7753     7755       +2     
- Partials      297      299       +2     
Files Changed Coverage Δ
internal/configs/version1/template_helper.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jjngx jjngx requested a review from a team August 15, 2023 09:21
@jjngx jjngx merged commit cba845e into main Aug 15, 2023
@jjngx jjngx deleted the feat/path-regex branch August 15, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants