Change links on NGINX Plus introduction page to relative links #4212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the reported issue in #4208 and changes other links on the same page to follow convention. Prior to this commit, the page had a combination of linking to the live, production URLs for other documentation while adding the markdown extension. Instead, the links now use the hugo relref (relative reference) convention for consistency, and have dropped the filename extension, fixing the links and giving them more consistent development behaviour.
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Files |
github-actions
bot
added
the
documentation
Codecov Report
@@ Coverage Diff @@
## main #4212 +/- ##
==========================================
- Coverage 51.93% 51.92% -0.02%
==========================================
Files 59 59
Lines 16743 16743
==========================================
- Hits 8696 8694 -2
- Misses 7748 7750 +2
Partials 299 299 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
vepatel
approved these changes
Aug 10, 2023
shaun-nx
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This commit fixes the reported issue in #4208 and changes other links on the same page to follow convention. Prior to this commit, the page had a combination of linking to the live, production URLs for other documentation while adding the markdown extension.
Instead, the links now use the hugo relref (relative reference) convention for consistency, and have dropped the filename extension, fixing the links and giving them more consistent development behaviour.
Checklist
Before creating a PR, run through this checklist and mark each as complete.