Skip to content

Conversation

pasmant
Copy link
Contributor

@pasmant pasmant commented Aug 8, 2023

Update file:
dos-protected.md
make field
dosAccessLogDest in resource DosProtectedResource - change to optional

@pasmant pasmant requested review from a team as code owners August 8, 2023 10:00
@github-actions github-actions bot added documentation Pull requests/issues for documentation tests Pull requests that update tests labels Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #4187 (845af43) into main (b44efbb) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4187      +/-   ##
==========================================
- Coverage   52.19%   52.17%   -0.03%     
==========================================
  Files          59       59              
  Lines       16930    16929       -1     
==========================================
- Hits         8837     8832       -5     
- Misses       7796     7798       +2     
- Partials      297      299       +2     
Files Changed Coverage Δ
internal/configs/dos.go 100.00% <100.00%> (ø)
pkg/apis/dos/validation/dos.go 97.22% <100.00%> (-0.06%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the docs side but most of this PR is code-based, so I'm deferring approval.

@shaun-nx shaun-nx added this to the v3.3.0 milestone Sep 7, 2023
Copy link
Contributor

@shaun-nx shaun-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me 👍

@shaun-nx shaun-nx merged commit 37ab8d6 into nginx:main Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests/issues for documentation tests Pull requests that update tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Field dosAccessLogDest of dos protected resource is mandatory

5 participants