-
Notifications
You must be signed in to change notification settings - Fork 2k
Dos access log dest #4187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dos access log dest #4187
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4187 +/- ##
==========================================
- Coverage 52.19% 52.17% -0.03%
==========================================
Files 59 59
Lines 16930 16929 -1
==========================================
- Hits 8837 8832 -5
- Misses 7796 7798 +2
- Partials 297 299 +2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on the docs side but most of this PR is code-based, so I'm deferring approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good to me 👍
Update file:
dos-protected.md
make field
dosAccessLogDest in resource DosProtectedResource - change to optional