Sign checksum with cosign #4181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds config to sign artifacts. Since the checksum contains the SHAs of the artifacts, signing the checksums is enough to ensure that the artifacts were not modified. GoReleaser uses cosign to sign the artifact and uploads .sig and .pem to the release.
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Files.github/workflows/ci.yml |
Codecov Report
@@ Coverage Diff @@
## main #4181 +/- ##
==========================================
- Coverage 51.95% 51.92% -0.03%
==========================================
Files 59 59
Lines 16743 16743
==========================================
- Hits 8698 8694 -4
- Misses 7748 7750 +2
- Partials 297 299 +2 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
vepatel
approved these changes
Aug 4, 2023
jjngx
approved these changes
Aug 4, 2023
haywoodsh
approved these changes
Aug 4, 2023
lucacome
added a commit
that referenced
this pull request
Aug 17, 2023
Adds config to sign artifacts. Since the checksum contains the SHAs of the artifacts, signing the checksums is enough to ensure that the artifacts were not modified. GoReleaser uses cosign to sign the artifact and uploads .sig and .pem to the release. (cherry picked from commit d64b566)
lucacome
added a commit
that referenced
this pull request
Aug 17, 2023
Adds config to sign artifacts. Since the checksum contains the SHAs of the artifacts, signing the checksums is enough to ensure that the artifacts were not modified. GoReleaser uses cosign to sign the artifact and uploads .sig and .pem to the release. (cherry picked from commit d64b566)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to
Adds config to sign artifacts. Since the checksum contains the SHAs of the artifacts, signing the checksums is enough to ensure that the artifacts were not modified.
GoReleaser uses cosign to sign the artifact and uploads .sig and .pem to the release.