Skip to content

Remove duplicated logic from templates #4176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 2, 2023
Merged

Remove duplicated logic from templates #4176

merged 2 commits into from
Aug 2, 2023

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Aug 2, 2023 •
edited
Loading

Proposed changes

This PR removes redundant logic from templates. It is a preliminary cleanup for work on the "master - minion" ingress work item.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner August 2, 2023 09:35
@github-actions github-actions bot added the enhancement Pull requests for new features/feature enhancements label Aug 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@jjngx jjngx requested review from haywoodsh, shaun-nx and vepatel August 2, 2023 09:35
shaun-nx
shaun-nx approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@shaun-nx shaun-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jjngx jjngx requested a review from a team August 2, 2023 09:46
@jjngx jjngx self-assigned this Aug 2, 2023
@jjngx jjngx merged commit 8b5b76f into main Aug 2, 2023
@jjngx jjngx deleted the feat/regex-annotation branch August 2, 2023 10:54
@danielnginx danielnginx added this to the v3.3.0 milestone Sep 21, 2023
@lucacome lucacome added chore Pull requests for routine tasks and removed enhancement Pull requests for new features/feature enhancements labels Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vepatel vepatel vepatel approved these changes

@haywoodsh haywoodsh Awaiting requested review from haywoodsh

+1 more reviewer

@shaun-nx shaun-nx shaun-nx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jjngx jjngx

Labels

chore Pull requests for routine tasks

Projects

None yet

Milestone

v3.3.0

Development

Successfully merging this pull request may close these issues.

5 participants

@jjngx @vepatel @shaun-nx @lucacome @danielnginx