Skip to content

Fix permissions in Helm job and Docker update #4145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2023
Merged

Fix permissions in Helm job and Docker update #4145

merged 2 commits into from
Jul 25, 2023

Conversation

@lucacome
Copy link

@lucacome lucacome commented Jul 25, 2023 •
edited
Loading

Proposed changes

  • The helm job didn't have the permissions needed to push the chart to GHCR
  • The calls to the re-usable workflow didn't pass permissions

@lucacome lucacome self-assigned this Jul 25, 2023
@lucacome lucacome requested a review from a team as a code owner July 25, 2023 00:45
@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2023 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@github-actions github-actions bot added the chore Pull requests for routine tasks label Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023 •
edited
Loading

Codecov Report

Merging #4145 (bb0146f) into main (8584737) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4145   +/-   ##
=======================================
  Coverage   51.84%   51.84%           
=======================================
  Files          59       59           
  Lines       16710    16710           
=======================================
  Hits         8664     8664           
  Misses       7747     7747           
  Partials      299      299

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lucacome lucacome changed the title Fix permissions in Helm job Fix permissions in Helm job and Docker update Jul 25, 2023
@lucacome lucacome merged commit ee391a4 into main Jul 25, 2023
@lucacome lucacome deleted the chore/fix-helm-permissions branch July 25, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vepatel vepatel vepatel approved these changes

+1 more reviewer

@shaun-nx shaun-nx shaun-nx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lucacome lucacome

Labels

chore Pull requests for routine tasks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lucacome @vepatel @shaun-nx