Skip to content

Add command line argument for custom TLS Passthrough port #4108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Aug 14, 2023
Merged

Add command line argument for custom TLS Passthrough port #4108

merged 16 commits into from
Aug 14, 2023

Conversation

haywoodsh
Copy link
Contributor

@haywoodsh haywoodsh commented Jul 14, 2023 •
edited
Loading

Proposed changes

Add flag for custom TLS Passthrough port. closes #4095

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the enhancement Pull requests for new features/feature enhancements label Jul 14, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2023 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@github-actions github-actions bot added documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart tests Pull requests that update tests labels Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023 •
edited
Loading

Codecov Report

Merging #4108 (3ac7115) into main (cace410) will increase coverage by 0.01%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##             main    #4108      +/-   ##
==========================================
+ Coverage   51.95%   51.96%   +0.01%     
==========================================
  Files          59       59              
  Lines       16753    16759       +6     
==========================================
+ Hits         8704     8709       +5     
- Misses       7750     7753       +3     
+ Partials      299      297       -2
Files Changed Coverage Δ
cmd/nginx-ingress/flags.go 30.14% <ø> (ø)
cmd/nginx-ingress/main.go 0.00% <0.00%> (ø)
internal/configs/config_params.go 77.77% <ø> (ø)
internal/configs/version1/config.go 0.00% <ø> (ø)
internal/k8s/controller.go 12.11% <ø> (ø)
internal/configs/configmaps.go 22.27% <100.00%> (+0.17%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@haywoodsh haywoodsh force-pushed the feat/custom-tls-passthrough-port branch 5 times, most recently from fb5fec9 to ce42e37 Compare July 26, 2023 11:14
@haywoodsh haywoodsh marked this pull request as ready for review July 26, 2023 14:56
@haywoodsh haywoodsh requested a review from a team as a code owner July 26, 2023 14:56
jjngx
jjngx reviewed Jul 26, 2023
View reviewed changes
vepatel
vepatel reviewed Aug 2, 2023
View reviewed changes
vepatel
vepatel reviewed Aug 2, 2023
View reviewed changes
vepatel
vepatel reviewed Aug 2, 2023
View reviewed changes
@haywoodsh haywoodsh requested a review from a team as a code owner August 8, 2023 14:08
ADubhlaoich
ADubhlaoich reviewed Aug 9, 2023
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM where docs are concerned: there's some issues with product naming but they existed in the docs prior to change and will be reviewed and updated as a discrete documentation task.

@haywoodsh haywoodsh force-pushed the feat/custom-tls-passthrough-port branch from 5f9c749 to 3ac7115 Compare August 11, 2023 11:22
shaun-nx
shaun-nx approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@shaun-nx shaun-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great stuff Haywood. The updated template tests are very clear and concise 👍

@jjngx
Copy link
Contributor

jjngx commented Aug 14, 2023

👍🏻 great job @haywoodsh

@haywoodsh haywoodsh merged commit 0302aca into main Aug 14, 2023
@haywoodsh haywoodsh deleted the feat/custom-tls-passthrough-port branch August 14, 2023 14:57
jjngx pushed a commit that referenced this pull request Aug 15, 2023
@haywoodsh @pre-commit-ci
@vepatel @jjngx
Add command line argument for custom TLS Passthrough port (#4108)
b56c6da 
* Allow custom port for TLS Passthrough
* update helm chart and add automated tests
---------

Signed-off-by: Haywood Shannon <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Venktesh Shivam Patel <[email protected]>
@haywoodsh haywoodsh self-assigned this Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich left review comments

@vepatel vepatel vepatel approved these changes

+2 more reviewers

@jjngx jjngx jjngx approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@haywoodsh haywoodsh

Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements helm_chart Pull requests that update the Helm Chart tests Pull requests that update tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add -tls-passthrough-port cli argument
5 participants
@haywoodsh @jjngx @ADubhlaoich @vepatel @shaun-nx