Skip to content

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Jul 13, 2023

Proposed changes

  • Disable AppProtect waf tests to unblock main

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested review from jjngx and shaun-nx July 13, 2023 09:34
@vepatel vepatel requested a review from a team as a code owner July 13, 2023 09:34
@github-actions github-actions bot added the tests Pull requests that update tests label Jul 13, 2023
@github-actions
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #4098 (0225316) into main (e69b9bc) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4098      +/-   ##
==========================================
+ Coverage   51.84%   51.86%   +0.01%     
==========================================
  Files          59       59              
  Lines       16710    16710              
==========================================
+ Hits         8664     8666       +2     
+ Misses       7747     7745       -2     
  Partials      299      299              

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vepatel vepatel merged commit 0621188 into main Jul 13, 2023
@vepatel vepatel deleted the tests/disable-ap-waf branch July 13, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Pull requests that update tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants