Skip to content

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Jul 10, 2023

Proposed changes

  • Update paths to test library and fixtures,
  • Update requirements.txt to use pinned hashes
 ~/nginx/kubernetes-ingress/perf-tests on tests/fix-perf-tests ● λ pytest -v -s -m ap_perf --service=loadbalancer
============================================================================== test session starts ==============================================================================
platform darwin -- Python 3.11.4, pytest-7.4.0, pluggy-1.2.0 -- /Users/ve.patel/.pyenv/versions/3.11.4/envs/kic_test/bin/python3.11
cachedir: .pytest_cache
metadata: {'Python': '3.11.4', 'Platform': 'macOS-13.3.1-arm64-arm-64bit', 'Packages': {'pytest': '7.4.0', 'pluggy': '1.2.0'}, 'Plugins': {'html': '3.2.0', 'flaky': '3.7.0', 'metadata': '3.0.0', 'profiling': '1.7.0'}}
rootdir: /Users/ve.patel/nginx/kubernetes-ingress
configfile: pyproject.toml
plugins: html-3.2.0, flaky-3.7.0, metadata-3.0.0, profiling-1.7.0
collected 4 items                                                                                                                                                               

suite/test_ap_reload_perf.py::TestAppProtectPerf::test_ap_perf_create_ingress[crd_ingress_controller_with_ap0] 
Tests will use this kubeconfig: /Users/<name>/.kube/config
Tests will use a current context: gke_<------>
Tests will use the image: nginx/nginx-ingress:edge
Tests will run with the image-pull-policy: IfNotPresent
Tests will use the IC deployment of type: deployment
Tests will run against the IC of type: nginx-ingress
Number of pods spun up will be : 1
Tests will use Service of this type: loadbalancer
All test fixtures be available for debugging: no, /// ONLY USE THIS OPTION FOR INDIVIDUAL TEST DEBUGGING ///
------------------------- Create IC Prerequisites  -----------------------------------
Create cluster role
Created role 'nginx-ingress'
Create binding

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested review from haywoodsh, jjngx and shaun-nx July 10, 2023 10:59
@vepatel vepatel requested a review from a team as a code owner July 10, 2023 10:59
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jul 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2023

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

perf-tests/requirements.txt

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #4085 (9d6ad48) into main (d88c475) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4085      +/-   ##
==========================================
- Coverage   51.88%   51.84%   -0.04%     
==========================================
  Files          59       59              
  Lines       16710    16710              
==========================================
- Hits         8670     8664       -6     
- Misses       7743     7747       +4     
- Partials      297      299       +2     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@vepatel vepatel merged commit 0a3b2d3 into main Jul 11, 2023
@vepatel vepatel deleted the tests/fix-perf-tests branch July 11, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants