Skip to content

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Jul 6, 2023

Proposed changes

This PR makes location zones metrics available for a dashboard / prometheus.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner July 6, 2023 12:06
@github-actions github-actions bot added the enhancement Pull requests for new features/feature enhancements label Jul 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #4080 (084b6df) into main (d88c475) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 084b6df differs from pull request most recent head 8f05fba. Consider uploading reports for the commit 8f05fba to get more accurate results

@@            Coverage Diff             @@
##             main    #4080      +/-   ##
==========================================
- Coverage   51.88%   51.87%   -0.02%     
==========================================
  Files          59       59              
  Lines       16710    16710              
==========================================
- Hits         8670     8668       -2     
- Misses       7743     7745       +2     
  Partials      297      297              

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jjngx jjngx added this to the v3.3.0 milestone Jul 6, 2023
jjngx added 3 commits July 7, 2023 11:45
Dashboard and Prometheus metrics for locations (services) will be displayed under names of corresponding services.
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jul 10, 2023
@jjngx jjngx requested a review from ADubhlaoich July 10, 2023 11:06
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jjngx jjngx requested review from a team and vepatel July 10, 2023 11:50
@jjngx jjngx merged commit e95ea2b into main Jul 10, 2023
@jjngx jjngx deleted the feat/extendedmetrics branch July 10, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants