Skip to content

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Jul 3, 2023

Proposed changes

Remove obsolete test placeholder

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner July 3, 2023 15:40
@jjngx jjngx requested a review from haywoodsh July 3, 2023 15:40
@github-actions github-actions bot added the tests Pull requests that update tests label Jul 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@jjngx jjngx requested a review from shaun-nx July 3, 2023 15:41
@jjngx jjngx requested a review from a team July 3, 2023 15:43
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #4072 (96bc38c) into main (e2fea37) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4072      +/-   ##
==========================================
- Coverage   51.87%   51.84%   -0.03%     
==========================================
  Files          59       59              
  Lines       16710    16710              
==========================================
- Hits         8668     8664       -4     
- Misses       7745     7747       +2     
- Partials      297      299       +2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jjngx jjngx merged commit b19ceba into main Jul 3, 2023
@jjngx jjngx deleted the test/endpointslice branch July 3, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants