Skip to content

Conversation

lucacome
Copy link

Proposed changes

Adds FIPS to the list of images and Docker commands. Also fixes names and formatting.

@lucacome lucacome added this to the v3.2.0 milestone Jun 23, 2023
@lucacome lucacome requested a review from a team June 23, 2023 02:41
@lucacome lucacome self-assigned this Jun 23, 2023
@lucacome lucacome requested a review from a team as a code owner June 23, 2023 02:41
@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2023

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jun 23, 2023
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #4048 (3c83791) into main (e65cc1d) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4048      +/-   ##
==========================================
+ Coverage   51.83%   51.87%   +0.03%     
==========================================
  Files          59       59              
  Lines       16705    16705              
==========================================
+ Hits         8659     8665       +6     
+ Misses       7747     7743       -4     
+ Partials      299      297       -2     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, made some very small suggestions that aren't blockers.

Copy link
Contributor

@jasonwilliams14 jasonwilliams14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@lucacome lucacome merged commit 2e27d62 into main Jun 23, 2023
@lucacome lucacome deleted the docs/fips branch June 23, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests/issues for documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants