Skip to content

Add support for controller.selectorLabels #3977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Add support for controller.selectorLabels #3977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63f2ad5
Fix the immutable matchlabels issue when upgrade helm to v3.1.x
hanyouqing Jun 8, 2023
e02f509
Update deployments/helm-chart/templates/_helpers.tpl
lucacome Jul 25, 2023
ddd2611
Merge branch 'main' into youqing/fix-the-immutable-matchlabels-issue-…
lucacome Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion deployments/helm-chart/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,13 @@ app.kubernetes.io/managed-by: {{ .Release.Service }}
Selector labels
*/}}
{{- define "nginx-ingress.selectorLabels" -}}
{{- if .Values.controller.selectorLabels -}}
{{ toYaml .Values.controller.selectorLabels }}
{{- else -}}
app.kubernetes.io/name: {{ include "nginx-ingress.name" . }}
app.kubernetes.io/instance: {{ .Release.Name }}
{{- end }}
{{- end -}}
{{- end -}}

{{/*
Expand the name of the configmap.
Expand Down
3 changes: 3 additions & 0 deletions deployments/helm-chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ controller:
## The kind of the Ingress Controller installation - deployment or daemonset.
kind: deployment

## The selectorLabels used to overide the default values.
selectorLabels: {}

## Annotations for deployments and daemonsets
annotations: {}

Expand Down