Remove explicit fsGroup definition
#3926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
6 tasks
sigv
force-pushed
the
defaultFsGroup
branch
2 times, most recently
from
63b18a5 to
325ac4e
Compare
Codecov Report
@@ Coverage Diff @@
## main #3926 +/- ##
=======================================
Coverage 51.81% 51.81%
=======================================
Files 59 59
Lines 16697 16697
=======================================
Hits 8651 8651
Misses 7747 7747
Partials 299 299 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sigv
force-pushed
the
defaultFsGroup
branch
7 times, most recently
from
2f3f5ec to
c987520
Compare
sigv
force-pushed
the
defaultFsGroup
branch
2 times, most recently
from
6e5806b to
e501948
Compare
jjngx
approved these changes
May 31, 2023
There is no use-case that is relevant for enforcing the `fsGroup` as the default user's group. Our `nginx` user will already have access to the volumes being created, as they are made with `g+rwx`.
lucacome
added
chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
There is no use-case that is relevant for enforcing the
fsGroupas the default user's group. Ournginxuser will already have access to the volumes being created, as they are made withg+rwx.Checklist
Before creating a PR, run through this checklist and mark each as complete.