Skip to content

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented May 11, 2023

Proposed changes

This PR introduces following changes:

  • TransportServer tests are executed in parallel
  • Negative and positive (happy) test paths are grouped in separate table tests

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Update TS tests to run in parallel, split negative and positive test scenarios into separate table tests
@jjngx jjngx requested a review from a team as a code owner May 11, 2023 04:51
@github-actions github-actions bot added the chore Pull requests for routine tasks label May 11, 2023
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #3892 (86a93fa) into main (ab67547) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3892      +/-   ##
==========================================
+ Coverage   51.94%   51.95%   +0.01%     
==========================================
  Files          59       59              
  Lines       16742    16742              
==========================================
+ Hits         8696     8698       +2     
+ Misses       7748     7746       -2     
  Partials      298      298              

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jjngx jjngx merged commit 7dd4a96 into main May 15, 2023
@jjngx jjngx deleted the chore/trsrv-tests branch May 15, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants