Skip to content

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented May 3, 2023

Proposed changes

  • Add correct indentation to controller-leader-election configmap helm template

Under current implementation helm install/upgrade throws a warning when reportIngressStatus.annotations is set in values.yaml

W0503 10:44:02.820672   62266 warnings.go:70] unknown field "annotations"

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested review from haywoodsh and ciarams87 May 3, 2023 10:01
@vepatel vepatel requested a review from a team as a code owner May 3, 2023 10:01
@github-actions github-actions bot added bug An issue reporting a potential bug helm_chart Pull requests that update the Helm Chart labels May 3, 2023
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #3840 (fc58391) into main (d0b8f1f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3840   +/-   ##
=======================================
  Coverage   52.39%   52.39%           
=======================================
  Files          59       59           
  Lines       16931    16931           
=======================================
  Hits         8871     8871           
  Misses       7761     7761           
  Partials      299      299           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vepatel vepatel merged commit a4cbe2f into main May 3, 2023
@vepatel vepatel deleted the fix/leader-election-cm-annotations branch May 3, 2023 11:56
@vepatel vepatel added this to the v3.1.1 milestone May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug helm_chart Pull requests that update the Helm Chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - Helm Chart: template "controller-leader-election-configmap" has incorrect indentation for annotations which breaks on apply
3 participants